minor(vest): staticSuite returns a promise #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
… (5.4.0) 91e415c patch(vest): Reduce Unneeded cache invalidations (ealush) e508549 patch(vest): Add a shared cache for preaggs (ealush) 145481a patch(vest): Cache useHasPending Call (ealush) bea35e2 minor(vest-utils): Add FindAll to IsolateWalker (ealush) eb515eb patch(vest): Reduce the number of times hasPending checks happen on test run (ealush) 8f74204 minor(vest): staticSuite returns a promise (#1144) (Evyatar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that when we use staticSuite, it actually returns a promise, so that we can directly await its response, without needing to use .done.